Clarify from_viewport_and_override logic
#21506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janis-bhm
added
D-Trivial
janis-bhm
approved these changes
Oct 11, 2025
Contributor
janis-bhm
left a comment
janis-bhm
left a comment
There was a problem hiding this comment.
Getting rid of the unwrap() is definitely an improvement! Personally, I do think it could be made even clearer with unwrap_or_default and/or map_or_else on the override.
alice-i-cecile
approved these changes
Oct 27, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
# Objective - This commit refactors the `from_viewport_and_override` function to improve readability and safety. ## Solution - Replaces the initial `cloned()` and subsequent `if/else` logic with a clearer `if let` structure. - Removes the need for `unwrap()` by handling both `Some` and `None` cases ## Testing - I don't know how to make sure there is no probelm, but I run some examples and I don't see the errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
from_viewport_and_overridefunction to improve readability and safety.Solution
cloned()and subsequentif/elselogic with a clearerif letstructure.unwrap()by handling bothSomeandNonecasesTesting